Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better sort admin user table. #3107

Merged
merged 1 commit into from
Jul 8, 2020
Merged

Better sort admin user table. #3107

merged 1 commit into from
Jul 8, 2020

Conversation

dracos
Copy link
Member

@dracos dracos commented Jul 7, 2020

Sort the table when showing search results, and show users without name at the bottom, rather than at the top.
Fixes https:/mysociety/fixmystreet-commercial/issues/1925

Sort the table when showing search results, and show users
without name at the bottom, rather than at the top.
@dracos dracos requested a review from struan July 7, 2020 12:18
Copy link
Member

@struan struan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@codecov
Copy link

codecov bot commented Jul 7, 2020

Codecov Report

Merging #3107 into master will decrease coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #3107      +/-   ##
==========================================
- Coverage   83.26%   83.26%   -0.01%     
==========================================
  Files         248      248              
  Lines       15559    15558       -1     
  Branches     2909     2909              
==========================================
- Hits        12955    12954       -1     
  Misses       1676     1676              
  Partials      928      928              
Impacted Files Coverage Δ
perllib/FixMyStreet/App/Controller/Admin/Users.pm 86.24% <100.00%> (-0.04%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d597f50...5405b21. Read the comment docs.

@dracos dracos merged commit 8070a84 into master Jul 8, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants